ShaderTweaks : Improve tweak creation when dragging parameters from the SceneInspector #6718
+86
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in comparison mode, the user may wish to drag values from either column. If both columns are selected, we take the first.
We now use `SceneInspector.draggedParameters()` to provide a consistent dict of parameter names and values when either a name or value is dragged from the Scene Inspector. This did require extending `draggedParameters()` to return disambiguated parameter names for non-output shaders, which was slightly more of a faff than I'd hoped. With this we now support creating multiple tweaks when multiple parameters are dragged from the Scene Inspector. We're not doing any checking here to prevent the same tweaks from being created again if they already exist, but that would be straightforward to support...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the recent addition of
SceneInspector.draggedParameters()we can improve the creation of ShaderTweaks from parameters dragged from the Scene Inspector, removing the need to drag both name and value when creating a tweak, and we now disambiguate the parameter name for non-output shaders.We now also support creating multiple tweaks when multiple parameters are dragged from the Scene Inspector.
I've left the existing ObjectMatrix support in
ShaderTweaksUI._TweaksFooter.__dropData(), but it might be worth removing if we have no other use for it?ShaderQuery would also benefit from similar functionality.