outputs.py : Move output definitions to non-gui configs #6564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Now tested with RenderMan as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a naive implementation of moving the output definitions to non-gui configs, so that they can be used from scripts that don't load the gui.
Just a simple cut-and-paste, but seems to be working. The only real question that came up is was the setup of the catalogue port ... I was trying to think whether there is any possible scenario where you want to use a catalogue without the UI. There's probably some theoretical way to use a catalogue non-interactively ( measure the brightness of different parts of the scene using a Catalogue connected to an ImageStats? ), but this feels extremely corner case. A simple cut-and-paste of the Catalogue setup into startup/GafferScene/outputs.py doesn't work because it doesn't get the
applicationvariable. So for now, I've just left the Catalogue setup in gui, which seems totally reasonable.I'm just doing a draft PR for now, since we've decided we're not going to try and push this out in 1.6 anyways. The only thing I'm aware of that needs to be done before merging is that I should do a basic test with RenderMan ( I'll probably need to get that set up next anyways ).
Resolves #6403