Open
Conversation
Merge latest changes from upstream to test compatibility before PR review.
- Replace old colors with new upstream colors - Remove unused color entries - Add GabePoel#6 for both themes Old → New: - #1e1e1e, #242424, #303030 → #1d1d20, #222226, #2e2e32 (dark) - #fafafa, #ebebeb → #fafafb, #ebebed (light) - #f2f2f2 → #f2f2f4 (kvconfig)"
- Fix line wrapping in description - Remove trailing whitespace in theme list - Fix code block formatting in kvctl.sh examples - Add missing closing code fence in Nix flake section - Fix indentation in Nix configuration examples - Clean up extra whitespace throughout
flake.nix: - Add flake-utils input for system iteration - Replace manual forAllSystems with flake-utils.lib.eachDefaultSystem - Simplify packages definition - Keep overlays and homeManagerModules outside system loop module.nix: - Import optionalAttrs from lib - Replace if-else with optionalAttrs for conditional xdg.configFile - Remove redundant with statements - Use explicit lib.mkIf instead of with lib - Clean up whitespace and formatting - Move pkgs. prefix to package references for clarity
- Replace printf with heredoc for cleaner output - Reduce line width to fit 79 characters - Align options and examples consistently - Remove excessive whitespace - Use standard indentation for help text
- Add --replace-warn for python3 -> ${python3}/bin/python3
- Update deprecated --replace to --replace-warn
- Fix "command not found" error in Nix sandbox
The kvctl.sh script needs explicit python3 path in Nix
derivations because buildInputs doesn't guarantee PATH
availability during installPhase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I know you don't actively maintain the repository, but I thought the feature might be useful and worth offering PR.
I have not modified the original theme project or any accompanying files.
Gradience works nearby.
For the build, I wrote a separate
kvctl.shscript to automatically install color overlays on KvLibadwaita.In README.md I outlined how the feature works. I also added the ability to declaratively set a theme for Nix users.