-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Integrate UNDP API for SDG data #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GYFX35
wants to merge
1
commit into
feat/initial-project-structure
Choose a base branch
from
feat/undp-api-integration
base: feat/initial-project-structure
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,9 +3,12 @@ document.addEventListener('DOMContentLoaded', () => { | |
| const chatInput = document.getElementById('chat-input'); | ||
| const chatWindow = document.getElementById('chat-window'); | ||
| const worldBankDataContainer = document.getElementById('world-bank-data'); | ||
| const undpDataContainer = document.getElementById('undp-data'); | ||
|
|
||
| // Fetch and display World Bank data on page load | ||
| fetchWorldBankData(); | ||
| // Fetch and display UNDP data on page load | ||
| fetchUNDPData(); | ||
|
|
||
| sendBtn.addEventListener('click', () => { | ||
| const userInput = chatInput.value; | ||
|
|
@@ -52,4 +55,40 @@ document.addEventListener('DOMContentLoaded', () => { | |
| worldBankDataContainer.innerHTML = `<p>Error fetching data: ${error.message}</p>`; | ||
| } | ||
| } | ||
|
|
||
| async function fetchUNDPData() { | ||
| try { | ||
| const response = await fetch('/api/sdg_data'); | ||
| if (!response.ok) { | ||
| throw new Error(`HTTP error! status: ${response.status}`); | ||
| } | ||
| const data = await response.json(); | ||
|
|
||
| if (data.error) { | ||
| undpDataContainer.innerHTML = `<p>Error fetching data: ${data.error}</p>`; | ||
| return; | ||
| } | ||
|
|
||
| if (data.length === 0) { | ||
| undpDataContainer.innerHTML = '<p>No UNDP data available for the selected countries.</p>'; | ||
| return; | ||
| } | ||
|
|
||
| let html = '<ul>'; | ||
| data.forEach(item => { | ||
| html += `<li><b>${item.country} (Target ${item.target_id}):</b> ${item.description} | ||
| <ul> | ||
| <li>Budget: $${item.budget ? item.budget.toFixed(2) : 'N/A'}</li> | ||
| <li>Expense: $${item.expense ? item.expense.toFixed(2) : 'N/A'}</li> | ||
| </ul> | ||
| </li>`; | ||
| }); | ||
| html += '</ul>'; | ||
|
|
||
| undpDataContainer.innerHTML = html; | ||
|
|
||
| } catch (error) { | ||
| undpDataContainer.innerHTML = `<p>Error fetching data: ${error.message}</p>`; | ||
| } | ||
| } | ||
|
Comment on lines
+59
to
+93
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue (code-quality): Avoid function declarations, favouring function assignment expressions, inside blocks. ( ExplanationFunction declarations may be hoisted in Javascript, but the behaviour is inconsistent between browsers. Hoisting is generally confusing and should be avoided. Rather than using function declarations inside blocks, you should use function expressions, which create functions in-scope. |
||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Potential for runtime errors if budget or expense is not a number.
Explicitly convert budget and expense to numbers before using toFixed, or use a formatting method that handles non-numeric values safely.