Open
Conversation
Solved tasks 1, 2A and 2B In progress 2C and 3 Tests 5, 6 and 7 are test cases for 2C and 3. I had previously written solutions for them in the code, but I removed them after I kept getting errors that were unexplainable to me. I tried implementing 2C by adding a counter for silences from the user in the IS, and updating that throughout the dialog. This updating and incrementing was quite confusing, and I though it be best to hand in the assignment and discuss the VG parts later.
vladmaraev
approved these changes
Oct 7, 2025
Member
vladmaraev
left a comment
vladmaraev
left a comment
There was a problem hiding this comment.
Well done with the G part of the lab! Nice to see the test for VG part being added, let me know if you have any questions regarding the VG part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved tasks 1, 2A and 2B
In progress 2C and 3
Tests 5, 6 and 7 are test cases for 2C and 3. I had previously written solutions for them in the code, but I removed them after I kept getting errors that were unexplainable to me. I tried implementing 2C by adding a counter for silences from the user in the IS, and updating that throughout the dialog. This updating and incrementing was quite confusing, and I though it be best to hand in the assignment and discuss the VG parts later.