Open
Conversation
Task 1, 2a, 2b, 2c, 3
vladmaraev
requested changes
Oct 7, 2025
Member
vladmaraev
left a comment
vladmaraev
left a comment
There was a problem hiding this comment.
Please see my comments regarding the task 2c. In addition, please provide some information of what you had implemented for task 3 (either as a comment or even better as a test case).
| }); | ||
|
|
||
|
|
||
| describe("Repeated no-input provides answer (Task 2c)", () => { |
Member
There was a problem hiding this comment.
Please implement the test where the system reaches the "final" state, i.e. provides information about the room.
| bel: Proposition[]; | ||
| last_no_input?: boolean; | ||
| no_input_count?: number; | ||
| no_input_processed?: boolean; // Added for Task 2c: Prevent multiple rule applications |
Member
There was a problem hiding this comment.
I am not sure if you understood the task 2c correctly. I meant that there you just need to ensure that if user correctly provides information (i.e. about the day) after several ASR_NOINPUTs system will still return correct information (i.e. the room number).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 1, 2a, 2b, 2c, 3