-
Notifications
You must be signed in to change notification settings - Fork 29
Add Option for sawn Lamps to be always a Light Level 15 #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
glowredman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this an optional change
no, i think lamps should always produce light also im evil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Become un-eviled (if you don't know how, ask. Someone (e.g. me) can help you)
looking over this again, this suggested option for lamps to not produce light, is not seen anywhere else in game. I don't know if having what looks up close to be florescent like lights, produce no light, is needed. I realistically cannot see anyone toggling that. If they want a block that doesn't produce light and looks the same, chisel has many. |
|
In addition to this, if someone wants a projectred lamp that looks the exact same in every way, but just does not produce light, non inverted lamp works as that. That could be changed to support being cut with a forge microblocks saw, but that would be in a different PR I believe Im not sure where that code is stored. We can merge this PR, then work on that if blocks that look like lamps that dont produce light are still wanted. |
|
we talked about it on the discord il just add a config option when i know how to add that, totally down for that i thought the point of the config was to make the glitched look default, apparently its just for in case someone wanted this behavior, but its not going to be default. :) totally good |


previously projected lamps sometimes produced no light, this should fix it