Skip to content

Conversation

@june-dev-username
Copy link

previously projected lamps sometimes produced no light, this should fix it

Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this an optional change

@june-dev-username
Copy link
Author

june-dev-username commented Jan 12, 2026

Please make this an optional change

no, i think lamps should always produce light

also im evil

Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Become un-eviled (if you don't know how, ask. Someone (e.g. me) can help you)

@june-dev-username
Copy link
Author

Become un-eviled (if you don't know how, ask. Someone (e.g. me) can help you)

looking over this again, this suggested option for lamps to not produce light, is not seen anywhere else in game. I don't know if having what looks up close to be florescent like lights, produce no light, is needed. I realistically cannot see anyone toggling that. If they want a block that doesn't produce light and looks the same, chisel has many.

@june-dev-username
Copy link
Author

june-dev-username commented Jan 26, 2026

this cleanly fixes what obviously looks like a visual bug, and looks horrendous in game

Screenshot from 2026-01-26 19-49-50

see image attached

having this just be gone for good is just a benefit

@june-dev-username
Copy link
Author

june-dev-username commented Jan 26, 2026

In addition to this, if someone wants a projectred lamp that looks the exact same in every way, but just does not produce light, non inverted lamp works as that. That could be changed to support being cut with a forge microblocks saw, but that would be in a different PR I believe Im not sure where that code is stored. We can merge this PR, then work on that if blocks that look like lamps that dont produce light are still wanted.

@june-dev-username
Copy link
Author

june-dev-username commented Jan 26, 2026

image another image of the horrible lamp

to elaborate, this is not a thing that affects anything else except the microblock version of the block. Any full block, togglable block, or redstone activated block, is not affected by this PR. It is purely a visual fix.

@june-dev-username
Copy link
Author

we talked about it on the discord il just add a config option when i know how to add that, totally down for that i thought the point of the config was to make the glitched look default, apparently its just for in case someone wanted this behavior, but its not going to be default. :) totally good

@glowredman glowredman changed the title Update lightmicroblocks.scala to remove glitch where lamps made no light Add Option for sawn Lamps to be always a Light Level 15 Jan 27, 2026
@glowredman glowredman merged commit b74820e into GTNewHorizons:master Jan 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants