fix coroutine.wrap in openOS #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing user programs using coroutine.wrap to ignore errors or in some cases get part of the error message as a string, instead of properly propagating the error like it should. The implementation is copied from machine.lua's sandboxed version of the method.
Dream-Master
added
the
🚧 Testing on Zeta
boubou19
approved these changes
Jan 5, 2026
Dream-Master
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lua reference manual says about
coroutine.wrap:The current implementation was not propagating the error. Instead, it was ignoring the status of the resume and returning the data as-is. This meant that user programs using coroutine.wrap would end up ignoring errors and getting part of the error message as a string.
The implementation is copied from machine.lua's sandboxed version of the method.