Backport modern Rosa Arcana behavior #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he ground and disenchant items which drops xp orbs (that it can later consume). Updated lang files to include modern info. Not all languages had the updated info in modern Botania, so I left them as they were.
koolkrafter5
added
enhancement
Nikolay-Sitnikov
requested changes
Nov 3, 2025
Nikolay-Sitnikov
left a comment
Nikolay-Sitnikov
left a comment
There was a problem hiding this comment.
The code looks good, the backported language changes less so.
Co-authored-by: Nikolay S. <nicksitnikov@gmail.com>
Nikolay-Sitnikov
approved these changes
Nov 3, 2025
22 tasks
UltraProdigy
pushed a commit
that referenced
this pull request
Dec 5, 2025
Co-authored-by: Nikolay S. <nicksitnikov@gmail.com>
boubou19
pushed a commit
that referenced
this pull request
Dec 5, 2025
Co-authored-by: koolkrafter5 <creepersrgreen@gmail.com> Co-authored-by: Nikolay S. <nicksitnikov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can pick up xp orbs nearby and disenchant items which drops xp orbs (that it can later consume):
Rosa.Demo.mp4
Updated lang files to include modern info. Not all languages had the updated info in modern Botania, so I left them as they were.
Based on https://github.com/VazkiiMods/Botania/blob/1.20.x/Xplat/src/main/java/vazkii/botania/common/block/flower/generating/RosaArcanaBlockEntity.java
Disenchanting items has a high chance for the xp orbs to just fly away from the Rosa, but modern Botania doesn't seem to have any mitigations for it so I left it like that for parity's sake.