remove cofhcore dep

[unix-supremacist]

i'm not even sure if the cofhlib dep is necessary in ae2fc it self, but since its what provides rfapi im assuming it is for ae2, and thus left it in the dependencies, it would probably be a good idea to have someone who actually uses the level maintainer double check no functionality is broken, but it really seems like only that one method which is a 1:1 copy from vanillas is used by it

[Kogepan229]

Could you make wrapFormattedStringToWidth public in the Access Transformer (ae2fc_at.cfg)?
That way, reflection wouldn't be necessary.

[Kogepan229]

Why do you want to remove cothcore? AE2 also depends on it, so removing it from ae2fc doesn't make much sense

[unix-supremacist]

ae2 does not depend on cofhcore, just cofhlib, thats a misconception, cofhlib is lgpl and includes the apis like redstone flux and the like, cofhcore is ARR, includes some extra stuff, but shades cofhlib, some of cofhcores asm is very broken, and yes some mods like bugtorch patch it, it's much better to just not use it when possible, especially since its ARR, and yeah i can use an AT instead, just though reflection was cleaner since it was 3 calls

[jss2a98aj]

For use outside of GTNH I can see the appeal of not depending on Cofhcore. It is known to introduce potential dupes and ghost item stack bugs to many modded and vanilla inventories if not using BugTorch with it.

[Kogepan229]

At least GTNH AE2 depends on cofhcore.
https://github.com/GTNewHorizons/Applied-Energistics-2-Unofficial/blob/d00982e2ca7a4d2d22a604b3a69bf5ce8c5d3949/dependencies.gradle#L6

If cofhlib is really sufficient, you should update it too.

[Kogepan229]

Also, use AT because reflection impairs readability.

[unix-supremacist]

gtnh AE2 pulls it as a dep, but if you just throw it in prod without it (atleast with cofhlib) it just works, ive been running it without cofhcore for awhile, i think someone just grabbed the wrong dep in dev because cofhcore shades cofhlib, i can update that too yeah, though it will probably be tomorrow before i get to doing that and the AT

[Dream-Master]

@unix-supremacist any news here ?

[unix-supremacist]

sorry kinda been busy, will take a look at this tomorrow

[Dream-Master]

@unix-supremacist @Kogepan229 seerver run fails because of missing lib. any idea ?
#407

[Dream-Master]

resolved