Skip to content

Fix Husky pre-commit hook#38

Open
luke9kim8 wants to merge 3 commits intomainfrom
luke9kim8/36-fix-husky
Open

Fix Husky pre-commit hook#38
luke9kim8 wants to merge 3 commits intomainfrom
luke9kim8/36-fix-husky

Conversation

@luke9kim8
Copy link
Contributor

Fix Husky pre-commit hook

Issue Number(s): #36

  • Add .husky/pre-commit by running npx install husky
  • pre-commit runs npx lint-staged before commiting
  • If the lint fails,

Checklist

Critical Changes

  • Add pre-commit hook

Related PRs

N/A

How to Test

  1. Try creating a project using the template
  2. Write some janky ugly js code
  3. Try commiting and see if pre-commt hook runs

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Deploy preview for nextjs-starter ready!

✅ Preview
https://nextjs-starter-mjqc30qkg-bitsofgood.vercel.app

Built with commit 48fbddd.
This pull request is being automatically deployed with vercel-action

@luke9kim8 luke9kim8 changed the title Luke9kim8/36 fix husky Fix Husky pre-commit hook Aug 7, 2022
Copy link

@therealsharath therealsharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! 🚢 it!

@therealsharath
Copy link

Nit: Mention in the README that husky/prettier won't work unless installed via npm/yarn :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants