Fix Availability Page style | Applicant Side #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alidah0
added
enhancement
alidah0
requested review from
Asmaathabet,
ahmadysalah,
hassanannajjar and
mFlaifel
tomduggan85
reviewed
Jun 11, 2020
| /> | ||
| <br /> | ||
|
|
||
| <Typography className="label">Mobile Number</Typography> |
There was a problem hiding this comment.
Another approach you could try (maybe next time) instead of having <br/> tags above every label is to give .label some margin-top in css.
tomduggan85
reviewed
Jun 11, 2020
| <Stepper nonLinear activeStep={activeStep}> | ||
| {steps.map((label, index) => ( | ||
| <Step key={label}> | ||
| <StepButton onClick={handleStep(index)}>{label}</StepButton> |
There was a problem hiding this comment.
I think your onClick handler won't quite work right, because what is happening is that you are calling handleStep(index) and passing its return value (which is probably undefined) as the onClick prop instead of actually passing in a function to onClick. Instead, you might need to rewrite it like this:
onClick={() => handleStep(index)}
tomduggan85
reviewed
Jun 11, 2020
| font-size: inherit; | ||
| } | ||
|
|
||
| .Container_page__availability .MuiSelect-selectMenu { |
There was a problem hiding this comment.
Nice job putting .Container_page__availability in front of each of these selectors!
relates #209
…into 209-fix-availabilty-style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates #209