Skip to content

Fix Cargo cache key to include source checksum (v4) #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rileyseaburg merged 1 commit into from
Dec 22, 2025
Merged

Fix Cargo cache key to include source checksum (v4) #1930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ jobs:

- restore_cache:
keys:
- v3-cargo-{{ checksum "ext/widget_renderer/Cargo.lock" }}
- v3-cargo-
- v4-cargo-{{ checksum "ext/widget_renderer/Cargo.lock" }}-{{ checksum "ext/widget_renderer/src/template_renderer.rs" }}
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache key only includes the checksum of template_renderer.rs, but the Rust project has multiple source files (form_data.rs, lib.rs, and template_renderer.rs). Changes to form_data.rs or lib.rs would not invalidate the cache, potentially causing stale builds. Consider using a checksum of the entire src directory or all .rs files instead of just template_renderer.rs. CircleCI supports checksumming directories, e.g., checksum "ext/widget_renderer/src" which would hash all files in the directory.

Suggested change
- v4-cargo-{{ checksum "ext/widget_renderer/Cargo.lock" }}-{{ checksum "ext/widget_renderer/src/template_renderer.rs" }}
- v4-cargo-{{ checksum "ext/widget_renderer/Cargo.lock" }}-{{ checksum "ext/widget_renderer/src" }}

Copilot uses AI. Check for mistakes.
- v4-cargo-{{ checksum "ext/widget_renderer/Cargo.lock" }}-

- run:
name: Build widget renderer (Rust)
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
- ext/widget_renderer/target
- ~/.cargo/registry
- ~/.cargo/git
key: v3-cargo-{{ checksum "ext/widget_renderer/Cargo.lock" }}
key: v4-cargo-{{ checksum "ext/widget_renderer/Cargo.lock" }}-{{ checksum "ext/widget_renderer/src/template_renderer.rs" }}
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache key only includes the checksum of template_renderer.rs, but the Rust project has multiple source files (form_data.rs, lib.rs, and template_renderer.rs). Changes to form_data.rs or lib.rs would not invalidate the cache, potentially causing stale builds. Consider using a checksum of the entire src directory or all .rs files instead of just template_renderer.rs. CircleCI supports checksumming directories, e.g., checksum "ext/widget_renderer/src" which would hash all files in the directory.

Copilot uses AI. Check for mistakes.

# Download and cache dependencies
- restore_cache:
Expand Down
Loading