Skip to content

Conversation

@rileyseaburg
Copy link
Contributor

Summary

  • Bump Cargo cache version from v2 to v3 to force full Rust rebuild
  • Bump widget_renderer version to 0.1.3

Problem

The previous deployment did not include the modal button fix because CircleCI was using a cached version of the Rust library. The cache key was based only on Cargo.lock, not the Rust source code (template_renderer.rs), so source code changes didn't trigger rebuilds.

Solution

Bump the cache version to invalidate the old cache and force a fresh build of the Rust widget renderer with the modal button fix.

The Cargo cache key was based only on Cargo.lock, not the Rust source code.
This meant changes to template_renderer.rs were not triggering rebuilds.
Bump cache version to v3 and widget_renderer version to 0.1.3 to force rebuild.
Copilot AI review requested due to automatic review settings December 22, 2025 17:40
@rileyseaburg rileyseaburg merged commit ed37d83 into production Dec 22, 2025
18 of 20 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR busts the CircleCI Cargo cache to force a complete rebuild of the Rust widget renderer library. The previous deployment failed to include a modal button fix because CircleCI cached the compiled Rust library based only on Cargo.lock, not the Rust source code changes.

Key changes:

  • Bumped Cargo cache version from v2 to v3 to invalidate existing cache
  • Bumped widget_renderer version from 0.1.1 to 0.1.3

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
ext/widget_renderer/Cargo.toml Updates package version to 0.1.3 to reflect the rebuild
Cargo.lock Reflects the version bump to 0.1.3 in the lock file
.circleci/config.yml Updates all three cache key references (restore with checksum, restore fallback, and save) from v2 to v3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[package]
name = "widget_renderer"
version = "0.1.1"
version = "0.1.3"
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is being bumped from 0.1.1 to 0.1.3, skipping 0.1.2. While this doesn't break functionality, it's unconventional and could cause confusion about what happened to version 0.1.2. If 0.1.2 was deployed but didn't include the modal button fix due to the cache issue, consider whether the version should follow sequential numbering for better version tracking. If there's a specific reason for skipping 0.1.2 (e.g., it was already tagged but not deployed correctly), this is acceptable but should be documented.

Suggested change
version = "0.1.3"
version = "0.1.2"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants