Don't Raise Error for ParentNotHarvestedException#149
Draft
nickumia-reisys wants to merge 6 commits intomainfrom
Draft
Don't Raise Error for ParentNotHarvestedException#149nickumia-reisys wants to merge 6 commits intomainfrom
ParentNotHarvestedException#149nickumia-reisys wants to merge 6 commits intomainfrom
Conversation
Not sure of the original intention, but we are removing this to make our harvester more reliable
nickumia-reisys
force-pushed
the
parent-not-harvested-bypass
branch
from
bcd40f2 to
5567291
Compare
nickumia-reisys
force-pushed
the
parent-not-harvested-bypass
branch
from
5567291 to
8f30b01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to
Notes:
ParentNotHarvestedExceptionwas causing thefetchprocess to crash too frequently. We thought we'd be able to remove it since the error is being logged. I believe that the current test is a bad test, it relies on retry logic that doesn't exist in production. However, to rewrite the test would take too much effort for me in my last days. So whoever comes to see this PR, it is a team decision on what should be done to either fix production or ignore the problem until we are on harvester 2.0.