[RESUB] - Allow Copying the Previous Report PDF#5446
Open
Conversation
Contributor
|
Terraform plan for meta No changes. Your infrastructure matches the configuration.📝 Plan generated in Pull Request Checks #562 |
Contributor
|
Terraform plan for dev Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2026-03-12T12:43:12Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy.📝 Plan generated in Pull Request Checks #562 |
Also, type annotations. We should do more of those.
Contributor
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow Copying the Previous Report PDF
Allows users to copy the report from the last submission in a resubmission chain. A chain of 2, most likely.
SOT compatible.
Related tickets
Description of changes
Functionality:
post.clean()override to remove any other errors if the user wants to copy.file_downloads.py, a new function to do the s3 file copy.Bonus changes:
test_views.pyinto/test_viewlib/test_upload_report_view.py. This is following precedent that I myself set and promptly forgot about.test_resubmission_start_view.pyutcnow()while I was poking around in the tests. There are a few more elsewhere, but I don't need to overstep in a PR that's gotten a little big.How to test
i. Start and finish a resubmission. Provide a brand new PDF when the time comes.
ii. Start a resubmission for your just-submitted record.
Screenshots and recordings
With the new checkbox selected:
