Skip to content

[RESUB] Provide original submission date for Federal users#5439

Open
RanyeM wants to merge 4 commits intomainfrom
orginal_submission_date
Open

[RESUB] Provide original submission date for Federal users#5439
RanyeM wants to merge 4 commits intomainfrom
orginal_submission_date

Conversation

@RanyeM
Copy link
Contributor

@RanyeM RanyeM commented Mar 11, 2026

Related tickets

#5241

Description of changes

Federal users need the original submission date for various oversight functions. Having that value to hand in all cases of viewing a resubmission is a substantial usability win.

  1. Add the "Original submission date" to the audit overview page. So, if you are looking at submission #3, it would have the "FAC Accepted Date" as well as the date for submission #1 in that chain.
  • This was covered already and merged into main through James' ticket, where it was originally 'First FAC submission date.'
  • renamed it to 'Original FAC submission date.'
  1. The resubmission API table should also provide the original_submission_date, so that upstream data consumers can easily do their computation. (This PR is covering this solution)

Screenshots and recordings

Screenshot 2026-03-11 at 10 04 14 AM

How to test

  • Log in as a Federal (FED) user.
  • Generate resubmissions using the appropriate scripts:
  1. resubmission-full
  2. menu.bash
  3. any other required resubmission generation scripts.
  • Navigate to Advanced Search.
  • Locate the generated resubmission records in the search results.
  • Open one of the resubmission summary views and locate the Original FAC submission date and the date in the resubmission table

@github-actions
Copy link
Contributor

This pull request is not up to date with main. Please merge main into this brach or rebase this branch onto main. This PR should not be approved until all status checks pass. If you see this message, please rerun all status checks before merging.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

📝 Plan generated in Pull Request Checks #547

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Terraform plan for dev

Plan: 2 to add, 1 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
!~  update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2026-03-10T19:23:42Z" -> (known after apply)
        }
    }

  # module.dev.module.newrelic.newrelic_nrql_alert_condition.db_slow_queries will be updated in-place
!~  resource "newrelic_nrql_alert_condition" "db_slow_queries" {
!~      enabled                        = true -> false
        id                             = "4900037:58210046"
        name                           = "DB Statement Duration Exceeds Threshold"
#        (18 unchanged attributes hidden)

#        (2 unchanged blocks hidden)
    }

  # module.dev.module.newrelic.newrelic_nrql_alert_condition.http_500_errors will be created
+   resource "newrelic_nrql_alert_condition" "http_500_errors" {
+       account_id                   = (known after apply)
+       aggregation_window           = (known after apply)
+       enabled                      = true
+       entity_guid                  = (known after apply)
+       id                           = (known after apply)
+       name                         = "HTTP 500 Errors Detected"
+       policy_id                    = 4900037
+       runbook_url                  = "https://github.com/GSA-TTS/fac-team/blob/main/troubleshooting/new-relic-queries.md"
+       title_template               = "DEV: {{conditionName}}"
+       type                         = "static"
+       violation_time_limit         = (known after apply)
+       violation_time_limit_seconds = 259200

+       nrql {
+           data_account_id = (known after apply)
+           query           = "SELECT count(*) FROM Transaction FACET `request.uri` WHERE response.status = '500' and appName = 'gsa-fac-dev'"
        }

+       warning {
+           disable_health_status_reporting = false
+           operator                        = "above"
+           threshold                       = 5
+           threshold_duration              = 300
+           threshold_occurrences           = "all"
        }
    }

Plan: 2 to add, 1 to change, 1 to destroy.

📝 Plan generated in Pull Request Checks #547

@github-actions
Copy link
Contributor

This pull request is not up to date with main. Please merge main into this brach or rebase this branch onto main. This PR should not be approved until all status checks pass. If you see this message, please rerun all status checks before merging.

@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 81%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 36% 0%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 85%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 68%
audit.templatetags 100% 100%
audit.views 72% 49%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 98% 100%
curation.curationlib 88% 72%
curation.migrations 100% 100%
dissemination 91% 70%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 62% 45%
dissemination.templatetags 52% 6%
dissemination.views 67% 48%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 78% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 88% (21918 / 24780) 69% (2693 / 3920)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant