Skip to content

Resub tagging refactor; adding version numbers#5436

Open
phildominguez-gsa wants to merge 17 commits intomainfrom
pd/resub-tags
Open

Resub tagging refactor; adding version numbers#5436
phildominguez-gsa wants to merge 17 commits intomainfrom
pd/resub-tags

Conversation

@phildominguez-gsa
Copy link
Contributor

@phildominguez-gsa phildominguez-gsa commented Mar 10, 2026

Related tickets

Description of changes

  • Using resubmission_status to simplify resubmission tagging in the search results
  • resub_tag_map wasn't being used, so I removed it. The tag data just gets added to the paginator results.
  • Adding version numbers to tags. V# first, followed by the descriptor. This was approved by Lynn!
  • Updating unit tests
image

How to test

  • Tags should appear correctly in advanced search
    • most_recent v0 or v1 should have no tag
    • most_recent v2+ should have a "MOST RECENT" tag
    • deprecated should have "RESUBMITTED" tag
  • You will need to make yourself a fed user to see them (instructions)
  • Don't forget to docker compose run web python manage.py materialized_views --create after you create submissions/resubmissions so they show up in advanced search

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

📝 Plan generated in Pull Request Checks #559

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Terraform plan for dev

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2026-03-12T12:43:12Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

📝 Plan generated in Pull Request Checks #559

@github-actions
Copy link
Contributor

This pull request is not up to date with main. Please merge main into this brach or rebase this branch onto main. This PR should not be approved until all status checks pass. If you see this message, please rerun all status checks before merging.

@github-actions
Copy link
Contributor

This pull request is not up to date with main. Please merge main into this brach or rebase this branch onto main. This PR should not be approved until all status checks pass. If you see this message, please rerun all status checks before merging.

@github-actions
Copy link
Contributor

This pull request is not up to date with main. Please merge main into this brach or rebase this branch onto main. This PR should not be approved until all status checks pass. If you see this message, please rerun all status checks before merging.

@phildominguez-gsa phildominguez-gsa changed the title Resub tagging mostly using status Resub tagging refactor; adding version numbers Mar 11, 2026
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 81%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 36% 0%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 85%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 68%
audit.templatetags 100% 100%
audit.views 72% 49%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 98% 100%
curation.curationlib 88% 72%
curation.migrations 100% 100%
dissemination 91% 70%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 43%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 78% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 88% (21889 / 24749) 69% (2682 / 3906)

Copy link
Contributor

@jperson1 jperson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

This is the most relatable thing I've ever seen:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RESUB] Update Resubmission Tag Logic to Use resubmission_status [SEARCH] - Resubmission Version Numbers

2 participants