Conversation
Member
|
This looks great! Can you add some evidence of a test to show that you get the right values. Ideally it would be a proper test of convergence or something, but I will accept e.g. a plot of the output over time for M = 2 a/M = 0.8. |
KAClough
added
the
enhancement
KAClough
reviewed
Aug 29, 2025
Examples/KerrBH/params_cheap.txt
Outdated
| 0 1 2 3 #Theta and Gamma | ||
| 0 1 2 3 1 2 3 #lapse shift and B | ||
| vars_parity_diagnostic = 0 1 2 3 #Ham and Mom | ||
| 0 0 #Madm and Jadm |
Member
There was a problem hiding this comment.
Can you align these with the values above?
Examples/KerrBH/params.txt
Outdated
| 0 1 2 3 #Theta and Gamma | ||
| 0 1 2 3 1 2 3 #lapse shift and B | ||
| vars_parity_diagnostic = 0 1 2 3 #Ham and Mom | ||
| 0 0 #Madm and Jadm |
KAClough
approved these changes
Sep 15, 2025
Member
KAClough
left a comment
KAClough
left a comment
There was a problem hiding this comment.
This is great, thanks @llibert94 for adding it to the public code! There are some features that could be added, like making the spin direction general, but this is good for now and we can upgrade it later if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request to recover Tiago's one in #121. It adds the feature for computing the ADM mass and spin of a spacetime in the KerrBH example. It uses eq. (7.15) in [arxiv:gr-qc/0703035] for the ADM mass, which differs slightly from eq. (3.128) in Baumgarte & Shapiro's book used in #121, and eq. (3.191) in Baumgarte & Shapiro's book for the ADM momentum.
When extracted in the KerrBH using the CCZ4 formalism and over a box of L=256M for a BH of mass=2M and spin a=0.8M
By doing the extrapolation to infinity using FitToInfinity.py in https://github.com/GRTLCollaboration/Postprocessing_tools/tree/feat/grchombo_and_gw_tools/PythonTools/DataAnalysis/GWTools, one gets the correct results, namely J=1.603717148220815458M^2 and mass=1.992012925023880276M