Skip to content

Conversation

Copy link

Copilot AI commented Dec 11, 2025

Addresses review feedback on PR #193 regarding unused code in the __onmeasurement callback method.

Changes

  • Removed message["simulation_id"] access in Simulation.__onmeasurement() that extracted but never used the value
  • The simulation ID is already stored as self.simulation_id when the simulation starts, making this extraction redundant
def __onmeasurement(self, headers, message):
    """Call the measurement callbacks"""
-   message["simulation_id"]  # Dead code
    timestamp = message["message"]["timestamp"]
    measurements = message["message"]["measurements"]
    for p in self.__filterable_measurement_callback_set:
        p[0](self, timestamp, measurements)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: craig8 <3979063+craig8@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback from Pixi update PR review Remove dead code accessing unused simulation_id in measurement callback Dec 12, 2025
Copilot AI requested a review from craig8 December 12, 2025 00:01
@craig8 craig8 marked this pull request as ready for review December 12, 2025 00:04
@craig8 craig8 merged commit 1689c18 into pixi-update Dec 12, 2025
1 check passed
@craig8 craig8 deleted the copilot/sub-pr-193 branch December 12, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants