Draft
Conversation
… into mem_release
|
looks promising, @V-Gorash please, review |
VGorash
approved these changes
Jul 7, 2023
Contributor
|
QA approved? |
Vsevolod1983
suggested changes
Jul 14, 2023
Vsevolod1983
left a comment
Vsevolod1983
left a comment
There was a problem hiding this comment.
Could you please
- Remove adding new files for all plugins except Houdini (i.e resourceWatcher.cpp and h)
- Put all function calls and include directives under houdini only macros
Vsevolod1983
approved these changes
Jul 18, 2023
|
as I understand, is this PR on draft? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PURPOSE
resolves: https://amdrender.atlassian.net/browse/RPRHOUD-40