node12: Updated to node 12/electron 7 #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI job failed: https://ci.gpii.net/job/gpii-app-tests/852/ |
|
CI job failed: https://ci.gpii.net/job/gpii-app-tests/854/ |
Also, updated to electron 7.x and enabled the nodeIntegration
* upstream/master: (146 commits) NOJIRA: Code review changes GPII-4474: fix footerTip bug GPII-4227: Added namespaced listener following review GPII-4422: Forcing the custom URL buttons to always use Chrome (if available). GPII-4231: Syncing up with sanitised Windows build now in master GPII-2338: Added the ability to start the windows service for testing. GPII-2338: Using GPII master for the siteconfig auto-update url GPII-2338: Updated service config to match what is being deployed. GPII-4425: Updated Vagrantfile to update Chrome and Firefox as windows does GPII-3730: Removing the link to JJ's branch because now its in the master GPII-4408: Terminating if a signalling command line option is used. GPII-4382: Pushing universal dependency update through the stack GPII-3958: Updaing to version of windows with stegru's build fix for the windows service GPII-4386: fix for duplicate custom buttons GPII-3958: Accommodate a model path name change introduced by the new PSPChannel API: activeContextName -> activePrefsSetName. GPII-4367: Temporary disabled the installer creation GPII-4367: Testing javihernandez/windows#GPII-4367 GPII-4065: Updated resetToStandardProfileUrl in siteConfig GPII-4296: Allow the custom config of the default settings url via the site config file. GPII-4065: Updated windows reference ...
|
CI job failed: https://ci.gpii.net/job/gpii-app-tests/1110/ |
|
CI job failed: https://ci.gpii.net/job/gpii-app-tests/1111/ |
javihernandez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for testing the update on CI only, do not merge.