Skip to content

Conversation

@kevina
Copy link
Member

@kevina kevina commented Mar 16, 2024

Continuation of #625.

Todo:

  • Test new code
  • Handle copyright
  • Add entry to ChangeLog and document the fact that the original filter is available under tex_v1

@kevina kevina changed the title Improved tex mode WIP: Improved tex mode Mar 16, 2024
@kevina kevina marked this pull request as draft March 16, 2024 20:53
@kevina kevina force-pushed the improved-tex-mode branch from 7210b63 to 904ee7c Compare March 16, 2024 21:08
@kevina kevina changed the title WIP: Improved tex mode Improved tex mode Mar 16, 2024
@kevina kevina marked this pull request as ready for review March 16, 2024 21:16
@kevina kevina mentioned this pull request Mar 16, 2024
@kevina
Copy link
Member Author

kevina commented Mar 16, 2024

@matthias314 I went ahead and addressed the two comments from #625. Can you please test this new code?

@kevina kevina force-pushed the improved-tex-mode branch from 904ee7c to fce5677 Compare March 16, 2024 22:30
@kevina kevina added this to the 0.60.9 milestone Mar 17, 2024
@matthias314
Copy link
Contributor

The new mode seems to work fine. However, I have the impression that the old mode has changed: For a file with content

$xy$

aspell used to complain about the "xy". The tex_v1 mode now accepts it, as does the new tex mode. Could it be that the old mode uses part of the new code?

A minor observation: If the list of modes produced by aspell modes can be sorted, then it might be a good idea to put the new TeX mode first.

@kevina
Copy link
Member Author

kevina commented Mar 18, 2024

However, I have the impression that the old mode has changed

This should be fixed now, the tex_v1 mode was using the tex filter by mistake.

If the list of modes produced by aspell modes can be sorted

At the moment is is not sorted and the order is non-deterministic.

@matthias314
Copy link
Contributor

This should be fixed now

Yes, now aspell behaves as before.

@kevina kevina force-pushed the improved-tex-mode branch from 04ed615 to cc8ad28 Compare March 31, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants