Skip to content

fix: set TRX/TRXT coin type to TRC-20#1740

Merged
CharlVS merged 2 commits intofeat/add-tron-coinsfrom
fix/trx-coin-type
Mar 18, 2026
Merged

fix: set TRX/TRXT coin type to TRC-20#1740
CharlVS merged 2 commits intofeat/add-tron-coinsfrom
fix/trx-coin-type

Conversation

@CharlVS
Copy link
Collaborator

@CharlVS CharlVS commented Mar 18, 2026

Summary

  • Fixes empty "type": "" for TRX and TRXT in generated coins_config.json
  • Root cause: get_protocol_info() only recognized ETH and QTUM as platform coin protocol types, but TRON uses its own distinct protocol type ("TRX") rather than "ETH" like other EVM chains (BNB, MATIC, AVAX, etc.)
  • Adds "TRX" to the platform protocol type check so it resolves to "TRC-20" via the existing self.protocols dict, consistent with how ETH → "ERC-20" and QTUM → "QRC-20" work

Changes

  • utils/generate_app_configs.py: Add "TRX" to protocol type list at line 282
  • utils/coins_config*.json: Regenerated — TRX and TRXT now have "type": "TRC-20"

Context

Related docs PR: GLEECBTC/komodo-docs-mdx#601

Test plan

  • Ran generate_app_configs.py no-scan locally — generation completes successfully
  • Verified TRX output: "type": "TRC-20" (was "")
  • Verified TRXT output: "type": "TRC-20" (was "")
  • Verified no regression on other coins (ETH still "ERC-20", BNB still "BEP-20", etc.)

CharlVS and others added 2 commits March 18, 2026 10:55
TRX and TRXT had an empty "type" field because the protocol type
resolution in get_protocol_info() only handled ETH and QTUM as
platform coin protocols. TRON uses its own protocol type ("TRX")
rather than "ETH", so it fell through all type-assignment paths.

Add "TRX" to the platform protocol check so TRX resolves to "TRC-20"
via the existing protocols dict, matching how ETH resolves to "ERC-20".
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@CharlVS CharlVS self-assigned this Mar 18, 2026
@CharlVS CharlVS requested a review from cipig March 18, 2026 10:05
@CharlVS CharlVS merged commit 9f87112 into feat/add-tron-coins Mar 18, 2026
@CharlVS CharlVS deleted the fix/trx-coin-type branch March 18, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants