Merged
Conversation
aaronjridley
approved these changes
Sep 16, 2025
Contributor
aaronjridley
left a comment
aaronjridley
left a comment
There was a problem hiding this comment.
These look good. I will test them out for the May 2005 storm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BUG/FEAT] Separate ionlimits for (non)advected species, fix lower temperature boundary, limit IMF
Title lists changes! These fixes help improve stability & physicality of simulations. Note, very intense storms may see slightly different outputs if IMF$B_y, B_z\gt \pm$ 40 nT, $V_x > \pm$ 1,500 nT, or density $\gt 50 $
Justification
Fixes the code!
Changes to outputs
Some. Nothing too large. Test's logfiles were all updated since the initial dt is different. Outputs (other than the ionlimit test) were hardly changed.