-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CameronZimmerman
wants to merge
31
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused packages and files * Add logic from sandbox, add chat logic * Move user management logic to its own module
… comments (#2) * Remove unused packages and files * Add logic from sandbox, add chat logic * Move user management logic to its own module * Initial re-copy of sandbox to fix cursor problems * Break out functions and add comments, make sure it still works.
Co-authored-by: Katrina Cloyd <‘Katrina.cloyd@yahoo.com’>
* Small addition to join event so number of online users can be easily broadcast. * Small addition to join event so number of online users can be easily broadcast.
* Small addition to join event so number of online users can be easily broadcast. * Send an object instead of just an ID on the new user event * Add an event to send existing users to client on join - commented out bc it is not working * Actually remember to comment it out
* added socket listen and emit for search input and button click * nav link hover socket working Co-authored-by: Katrina Cloyd <‘Katrina.cloyd@yahoo.com’>
* added socket listen and emit for search input and button click * nav link hover socket working * header click socket handling Co-authored-by: Katrina Cloyd <‘Katrina.cloyd@yahoo.com’>
Co-authored-by: Katrina Cloyd <‘Katrina.cloyd@yahoo.com’>
* Small addition to join event so number of online users can be easily broadcast. * Commit to pull
* socket handlers for answers and DUCK * socket handling for mission section hover Co-authored-by: Katrina Cloyd <‘Katrina.cloyd@yahoo.com’>
* started the read me * adding socket stuff, commiting to pull * commiting to pull * added on footer title click socket * added comment
* socket handlers for answers and DUCK * socket handling for mission section hover * footer transparent click and points sockets Co-authored-by: Katrina Cloyd <‘Katrina.cloyd@yahoo.com’>
* added dont click functionality to join us dropdown menu * Update server.js
* socket handlers for answers and DUCK * socket handling for mission section hover * footer transparent click and points sockets * socket handling for ghost image clicks Co-authored-by: Katrina Cloyd <‘Katrina.cloyd@yahoo.com’>
* socket data for five highlights challenge * make sure room goes forward if game is in progress
* missing curly brace * second missing curly
* missing curly brace * second missing curly * fix user cap
* missing curly brace * second missing curly * fix user cap * fix user cap again
* added dont click functionality to join us dropdown menu * added onDontClickPoints function
* added dont click functionality to join us dropdown menu * added onDontClickPoints function * added btnClicked to client emit and socket emit to send updated values
* call finish on test end * detect open handles * detect open handles for regular npm run test * try to close out http server * circumvent open handles
Co-authored-by: Katrina Cloyd <‘Katrina.cloyd@yahoo.com’>
KatrinaCloyd
approved these changes
Jun 18, 2021
juliannevela
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.