Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 18, 2025

The output directory was hardcoded as "output" across five target classes in diffusion_sampling.py. This addresses feedback to centralize the configuration.

Changes

  • Added module-level constant OUTPUT_DIR = "output" alongside TERMINAL_TIME_EPS
  • Replaced hardcoded strings in visualize() methods for:
    • SimpleGaussianMixture
    • Grid25GaussianMixture
    • Posterior9of25GaussianMixture
    • Funnel
    • ManyWell
# Before
os.makedirs("output", exist_ok=True)
plt.savefig(f"output/{prefix}simple_gmm.png")

# After
os.makedirs(OUTPUT_DIR, exist_ok=True)
plt.savefig(f"{OUTPUT_DIR}/{prefix}simple_gmm.png")

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: josephdviviano <4142570+josephdviviano@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on relative trajectory balance implementation Refactor: Extract OUTPUT_DIR constant for visualization paths Dec 18, 2025
Copilot AI requested a review from josephdviviano December 18, 2025 04:07
Copy link
Collaborator

@josephdviviano josephdviviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@josephdviviano josephdviviano marked this pull request as ready for review December 18, 2025 04:14
@josephdviviano josephdviviano merged commit 97a2453 into relative_trajectory_balance Dec 18, 2025
3 checks passed
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.33%. Comparing base (ad457f6) to head (b141f3f).
⚠️ Report is 3 commits behind head on relative_trajectory_balance.

Files with missing lines Patch % Lines
src/gfn/gym/diffusion_sampling.py 9.09% 10 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           relative_trajectory_balance     #459   +/-   ##
============================================================
  Coverage                        74.33%   74.33%           
============================================================
  Files                               48       48           
  Lines                             7111     7112    +1     
  Branches                           830      830           
============================================================
+ Hits                              5286     5287    +1     
  Misses                            1503     1503           
  Partials                           322      322           
Files with missing lines Coverage Δ
src/gfn/gym/diffusion_sampling.py 48.75% <9.09%> (+0.12%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants