fix: improper membership checks for public BM/GMM body pages #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the same logic is used in all places. For someone to be considered part of the BM/GMM body they must be installed today or in the past. Furthermore, they may not have been discharged (if discharge in the future they are still part).
tomudding
force-pushed
the
fix/discharge-date-not-accounted-for-on-body-page
branch
from
53aebb0 to
5bac369
Compare
tomudding
changed the title
github-actions bot
added a commit
that referenced
this pull request
Jun 19, 2025
Tom Udding: Merge pull request #2025 from tomudding/fix/discharge-date-not-accounted-for-on-body-page fix: improper membership checks for public BM/GMM body pages Co-authored-by: tomudding <tomudding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The same flaw in the logic was fixed in abcb082
and dd94226 but somehow this part of the code
was missed.
Related issues/external references
N/A
Types of changes