Skip to content

chore: voting committee foundation decision from GEWISDB #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomudding merged 1 commit into from
Jun 11, 2025
Merged

chore: voting committee foundation decision from GEWISDB #2024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions module/Application/language/en.po
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions module/Application/language/gewisweb.pot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions module/Application/language/nl.po
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions module/Application/view/partial/main-nav.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,11 @@ endif; ?>
<?= OrganTypes::AVW->getPluralName($translator) ?>
</a>
</li>
<li>
<a href="<?= $this->url('home/gmm_bodies/sc_list') ?>">
<?= OrganTypes::SC->getPluralName($translator) ?>
</a>
</li>
<li>
<a href="<?= $this->url('home/gmm_bodies/avc_list') ?>">
<?= OrganTypes::AVC->getPluralName($translator) ?>
Expand Down
3 changes: 3 additions & 0 deletions module/Decision/src/Model/Enums/OrganTypes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ enum OrganTypes: string
case KCC = 'kcc';
case AVW = 'avw';
case RvA = 'rva';
case SC = 'sc';

public function getName(Translator $translator): string
{
Expand All @@ -27,6 +28,7 @@ public function getName(Translator $translator): string
self::KCC => $translator->translate('Financial Audit Committee'),
self::AVW => $translator->translate('GMM Taskforce'),
self::RvA => $translator->translate('Advisory Board'),
self::SC => $translator->translate('Voting Committee'),
};
}

Expand All @@ -39,6 +41,7 @@ public function getPluralName(Translator $translator): string
self::KCC => $translator->translate('Financial Audit Committees'),
self::AVW => $translator->translate('GMM Taskforces'),
self::RvA => $translator->translate('Advisory Boards'),
self::SC => $translator->translate('Voting Committees'),
};
}
}
1 change: 1 addition & 0 deletions module/Decision/src/Service/Organ.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ public function getEditableOrgans(): array
$this->findActiveOrgansByType(OrganTypes::AVW),
$this->findActiveOrgansByType(OrganTypes::KCC),
$this->findActiveOrgansByType(OrganTypes::RvA),
$this->findActiveOrgansByType(OrganTypes::SC),
);
}

Expand Down
9 changes: 9 additions & 0 deletions module/Frontpage/config/module.config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,15 @@
],
],
],
'sc_list' => [
'type' => Literal::class,
'options' => [
'route' => '/voting-committees',
'defaults' => [
'action' => 'scList',
],
],
],
],
],
],
Expand Down
5 changes: 5 additions & 0 deletions module/Frontpage/src/Controller/OrganController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ public function rvaListAction(): ViewModel
return $this->getBodies(OrganTypes::RvA);
}

public function scListAction(): ViewModel
{
return $this->getBodies(OrganTypes::SC);
}

private function getBodies(OrganTypes $organType): ViewModel
{
return new ViewModel([
Expand Down
4 changes: 4 additions & 0 deletions module/Frontpage/view/frontpage/organ/organ.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,10 @@ function getOrganDescription($organInformation, $lang)
<a href="<?= $this->url('home/gmm_bodies/rva_list') ?>">
<?= OrganTypes::RvA->getPluralName($translator) ?>
</a>
<?php elseif (OrganTypes::SC === $organ->getType()): ?>
<a href="<?= $this->url('home/gmm_bodies/sc_list') ?>">
<?= OrganTypes::SC->getPluralName($translator) ?>
</a>
<?php endif; ?>
</li>
<li class="active">
Expand Down
Loading