feat(activity): promoted ordering of signup lists #2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may happen that an activity has more than one signup list, in certain cases it may be preferred to use a different ordering than when the activity was made. For example, when it is decided that an activity should be re-opened for signups but you want to preserve the original signup list I have to manually create a new signup list for this activity. To ensure that it is the first signup list in the overview, I have to make manual changes in the database to fix the positioning by altering the IDs of the signup lists (which is a pain). Therefore, this introduces a structured approach to handle ordering directly within the codebase. The functionality is *NOT* exposed to activity organisers. Although more complex ordering (like considering signup list open/close times) is possibly better, it is currently out-of-scope for this implementation (as I am not entirely sure it is possible with Doctrine without have to create custom queries).
github-actions bot
added a commit
that referenced
this pull request
May 1, 2025
Tom Udding: Merge pull request #2018 from tomudding/feature/promoted-signup-list feat(activity): promoted ordering of signup lists Co-authored-by: tomudding <tomudding@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It may happen that an activity has more than one signup list, in certain cases it may be preferred to use a different ordering than when the activity was made.
For example, when it is decided that an activity should be re-opened for signups but you want to preserve the original signup list I have to manually create a new signup list for this activity. To ensure that it is the first signup list in the overview, I have to make manual changes in the database to fix the positioning by altering the IDs of the signup lists (which is a pain).
Therefore, this introduces a structured approach to handle ordering directly within the codebase. The functionality is NOT exposed to activity organisers.
Although more complex ordering (like considering signup list open/close times) is possibly better, it is currently out-of-scope for this implementation (as I am not entirely sure it is possible with Doctrine without have to create custom queries).
Related issues/external references
Related to ABC-2505-TBD.
Types of changes