fix(attendance-mode): fix wrong default value for Signup entity

[LuukBlankenstijn]

Description

A small bug I found that caused me a lot of confusion. To fix everything, it would be nice to run the following query against the live database: UPDATE SIGNUP SET drawn = TRUE. Since the drawing functionality has not really been used yet, it does not matter this resets everything.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

[tomudding]

Maybe I do not understand the functionality, but the default should be false not true? Because you cannot be drawn by default, however, then the real fix would be setting the following to true?

gewisweb/module/Activity/src/Controller/AdminController.php

Line 619 in 0da8697

$signup->setDrawn(false);

[LuukBlankenstijn]

Well, right now the default is true. Since there is no policy (implemented) (yet), everyone is "drawn" in by default, and then you can "draw" them out in the admin interface. The actual draw is made by the used by hand.

[tomudding]

I personally disagree that the default state should be that you are ingeloot; imho everyone should start uitgeloot, and then the draw awards you a spot.

That way, you make it an active decision (either manually or programmatically -in the future) to award someone the spot and prevent people from staying ingeloot while they should become uitgeloot (because of whatever reason we fail to save the state); in other words, we fail safely.