fix: comparisons for discharge/abrogation dates #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomudding
force-pushed
the
fix/discharge-and-abrogation-date-comparisons
branch
from
ddb5c22 to
dd94226
Compare
github-actions bot
added a commit
that referenced
this pull request
Dec 11, 2024
Tom Udding: Merge pull request #1938 from tomudding/fix/discharge-and-abrogation-date-comparisons fix: comparisons for discharge/abrogation dates Co-authored-by: tomudding <tomudding@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some differences existed between what is meant and what was implemented. Also compared to GEWISDB, some checks were incorrect.
Related issues/external references
This
cherry-picks commit 1b1f945 from GH-1903 and fixes GH-1862.Types of changes