Skip to content

fix: traction update with hasConfigurationConvergedGlobally #3925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paveltomin merged 7 commits into from
Dec 19, 2025
Merged

fix: traction update with hasConfigurationConvergedGlobally #3925

paveltomin merged 7 commits into from
Dec 19, 2025

Conversation

@jhuang2601
Copy link
Contributor

@jhuang2601 jhuang2601 commented Dec 18, 2025 •
edited
Loading

This PR

  • added the traction update for ALM solver if hasConfigurationConvergedGlobally, which was wrongly deleted in PR#3522
  • added a smoke test with curved fractures

@jhuang2601 jhuang2601 self-assigned this Dec 18, 2025
@jhuang2601 jhuang2601 added type: bug Something isn't working flag: ready for review EPIC - FF/Contact Contact mechanics labels Dec 18, 2025
@jhuang2601 jhuang2601 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests labels Dec 18, 2025
@jhuang2601
Copy link
Contributor Author

jhuang2601 commented Dec 18, 2025

Expected failure for cases with ALM and rebaseline is required

=======================
Test failures
=======================
ALM_SimpleCubes_smoke_01
ALM_SimpleCubes_smoke_08
ALM_SimpleCubes_smoke_09
ALM_SingleFracCompression_smoke_01
ALM_SingleFracCompression_smoke_04
ALM_Sneddon_smoke_01
ALM_Sneddon_smoke_04
ALM_TFrac_smoke_01
ALM_TFrac_smoke_04
ALM_UnstructuredCrack_smoke_01
ALM_UnstructuredCrack_smoke_04
PoroElastic_ALM_conformingFracture_2d_openingFrac_horizontal_sequential_smoke_01
PoroElastic_ALM_conformingFracture_2d_openingFrac_horizontal_sequential_smoke_04
PoroElastic_ALM_conformingFracture_2d_openingFrac_vertical_sequential_smoke_01
PoroElastic_ALM_conformingFracture_2d_openingFrac_vertical_sequential_smoke_04
PoroElastic_ALM_curvedFrac_smoke_01
PoroElastic_ALM_curvedFrac_smoke_04
=======================
Overall status: FAILED
=======================

@paveltomin paveltomin merged commit e998203 into develop Dec 19, 2025
22 of 23 checks passed
@paveltomin paveltomin deleted the feature/jhuang/tractionUpdate branch December 19, 2025 03:35
@jafranc
Copy link
Contributor

jafranc commented Dec 19, 2025

This potential regression was introduced in 503872a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paveltomin paveltomin paveltomin approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren Guotong-Ren is a code owner

@matteofrigo5 matteofrigo5 Awaiting requested review from matteofrigo5 matteofrigo5 is a code owner

@jafranc jafranc Awaiting requested review from jafranc

@npillardou npillardou Awaiting requested review from npillardou

@herve-gross herve-gross Awaiting requested review from herve-gross

Assignees

@jhuang2601 jhuang2601

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI EPIC - FF/Contact Contact mechanics flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhuang2601 @jafranc @paveltomin