Skip to content

Conversation

@bd713
Copy link
Contributor

@bd713 bd713 commented Dec 10, 2025

After PR #3856 introduced external error detection, VTK's informational messages are being incorrectly flagged as error.

This PR adds filtering in the external error handler lambda (in initializeEnvironment.cpp) to skip messages containing INFO| patterns before treating them as errors.

Before:

***** ERROR
***** LOCATION: (external error, detected post GEOS loading)
2025-12-01 10:26:29.658 (   1.194s) [    7FC6BFD99040]    vtkExtractEdges.cxx:329   INFO| Executing edge extractor with original point numbering

** StackTrace of 6 frames **
Frame 0: geos::OutputStreamDeviation::flush(std::function<void (std::basic_string_view<char, std::char_traits<char> >, std::basic_string_view<char, std::char_traits<char> >)> const&, std::basic_string_view<char, std::char_traits<char> >) 
Frame 1: geos::EventManager::run(geos::DomainPartition&) 
Frame 2: geos::GeosxState::run() 
Frame 3: main 
Frame 4: /lib64/libc.so.6 
Frame 5: __libc_start_main 
Frame 6: _start 
=====

After:

2025-12-10 16:25:31.316 (   0.510s) [    7FE267A91040]    vtkExtractEdges.cxx:329   INFO| Executing edge extractor with original point numbering

@bd713 bd713 self-assigned this Dec 10, 2025
@bd713 bd713 added type: bug Something isn't working flag: no rebaseline Does not require rebaseline labels Dec 10, 2025
@MelReyCG MelReyCG added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Dec 11, 2025
Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing it.

@MelReyCG MelReyCG merged commit 6d2b61f into develop Dec 16, 2025
22 of 23 checks passed
@MelReyCG MelReyCG deleted the fix/bd713/fix_filterINFO branch December 16, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants