-
Notifications
You must be signed in to change notification settings - Fork 97
feat: split FiniteElementBase into nonvirtual and virtual interfaces #3725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rrsettgast
wants to merge
56
commits into
develop
Choose a base branch
from
feature/reworkFiniteElement
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ageous on CPU architectures after Haswell
850a4cc to
89e9006
Compare
…t fix, mass kernel tweaks.
Collaborator
|
@rrsettgast Looks like we're good to go on this, all integrated tests passing. |
…st-device lambda issue
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3725 +/- ##
===========================================
- Coverage 58.93% 58.86% -0.07%
===========================================
Files 1351 1352 +1
Lines 112834 112891 +57
===========================================
- Hits 66499 66455 -44
- Misses 46335 46436 +101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removed multiplication by GL_BASIS weights from return statement.
…to trace nan source
…boundary condition application (sidestep private/protected access host-device lambda) and remove redundant NaN/Inf checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: run code coverage
enables running of the code coverage CI jobs
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to remove the issues caused by the virtual destructor in FIniteElementBase.
FiniteElementBase