Skip to content

Conversation

@rrsettgast
Copy link
Member

@rrsettgast rrsettgast commented Jul 13, 2025

This PR seeks to remove the issues caused by the virtual destructor in FIniteElementBase.

  • Remove operations from FiniteElementBase
  • Split derived types into virtual and non-virtual types.
  • use the non-virtual types in device kernels.

@rrsettgast rrsettgast added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jul 14, 2025
@rrsettgast rrsettgast force-pushed the feature/reworkFiniteElement branch from 850a4cc to 89e9006 Compare September 17, 2025 21:01
@wrtobin
Copy link
Collaborator

wrtobin commented Dec 5, 2025

@rrsettgast Looks like we're good to go on this, all integrated tests passing.

@rrsettgast rrsettgast added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run code coverage enables running of the code coverage CI jobs and removed DO NOT MERGE ! labels Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 39.51049% with 346 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.86%. Comparing base (654a813) to head (ee3a9ad).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...aceGeneration/kernels/surfaceGenerationKernels.hpp 0.00% 50 Missing ⚠️
...ers/solidMechanics/SolidMechanicsLagrangianFEM.cpp 0.00% 38 Missing ⚠️
...entFormulations/H1_Tetrahedron_Lagrange1_Gauss.hpp 15.15% 28 Missing ⚠️
...sicsSolvers/surfaceGeneration/SurfaceGenerator.cpp 0.00% 28 Missing ⚠️
...lations/H1_Hexahedron_Lagrange1_GaussLegendre2.hpp 20.00% 20 Missing ⚠️
...lementFormulations/H1_Pyramid_Lagrange1_Gauss5.hpp 23.07% 20 Missing ⚠️
.../elementFormulations/H1_Wedge_Lagrange1_Gauss6.hpp 24.00% 19 Missing ⚠️
...entFormulations/ConformingVirtualElementOrder1.hpp 0.00% 15 Missing ⚠️
...rmulations/Qk_Hexahedron_Lagrange_GaussLobatto.hpp 69.38% 15 Missing ⚠️
...niteElement/elementFormulations/BB_Tetrahedron.hpp 36.36% 14 Missing ⚠️
... and 26 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3725      +/-   ##
===========================================
- Coverage    58.93%   58.86%   -0.07%     
===========================================
  Files         1351     1352       +1     
  Lines       112834   112891      +57     
===========================================
- Hits         66499    66455      -44     
- Misses       46335    46436     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants