-
Notifications
You must be signed in to change notification settings - Fork 97
feat: Single-phase reactive transport combined with HPCReact #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rrsettgast
merged 121 commits into
develop
from
feature/singlePhaseReactiveTransportWithHPCReact
Jan 3, 2026
Merged
feat: Single-phase reactive transport combined with HPCReact #3634
rrsettgast
merged 121 commits into
develop
from
feature/singlePhaseReactiveTransportWithHPCReact
Jan 3, 2026
+11,851
−2,070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…inglePhaseReactiveTransport
…d' into feature/singlePhaseReactiveTransportWithHPCReact
…ture/singlePhaseReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…d' into feature/singlePhaseReactiveTransportWithHPCReact
…eReactiveTransportWithHPCReact
…portWithHPCReact' into feature/singlePhaseReactiveTransportWithHPCReact
…thub.com:GEOS-DEV/GEOS into feature/singlePhaseReactiveTransportWithHPCReact
herve-gross
approved these changes
Dec 23, 2025
Contributor
herve-gross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to avoid holding this up, but I have not looked at the code in detail.
rrsettgast
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changes XML input
ci: run code coverage
enables running of the code coverage CI jobs
ci: run CUDA builds
Allows to triggers (costly) CUDA jobs
ci: run integrated tests
Allows to run the integrated tests in GEOS CI
flag: ready for review
flag: requires rebaseline
Requires rebaseline branch in integratedTests
flag: requires updated submodule(s)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch aims to implement the single-phase reactive transport model into GEOS. The following tasks are listed for completion:
SinglePhaseReactiveTransportsolver (derived fromSinglePhaseBase) that contains all needed functions to solve the problem andSinglePhaseReactiveTransportFields.hppto store all necessary fieldsAccumulationKernelandFluxComputeKernelto assemble the local rhs and matrixReactiveSinglePhaseFluidconstitutive modeltestSinglePhaseReactiveTransportto verify the implementation of Jacobian matrixsurfaceArea(added but need test)