Conversation
# Conflicts: # .github/workflows/ci.yml
There was a problem hiding this comment.
Pull request overview
This PR enables automated PyPI publishing for the snaplint project by activating a previously commented-out workflow job and bumping the package version to 0.5.0. The workflow uses GitHub's trusted publishing mechanism with OIDC authentication, eliminating the need for API tokens while maintaining security through environment-based deployment controls.
Key Changes:
- Activated the
publish-releaseworkflow job with trusted publishing configuration andpypi-productionenvironment - Bumped version from 0.4.2 to 0.5.0 in preparation for release
- Updated lock file to reflect the new version
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Enabled the publish-release job to automate PyPI publishing using trusted publishing with appropriate OIDC permissions |
pyproject.toml |
Updated project version from 0.4.2 to 0.5.0 |
uv.lock |
Updated lock file to reflect the new version in the package metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -136,6 +136,7 @@ jobs: | |||
| publish-release: | |||
| needs: build-release | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
The publish-release job will execute on every successful build, including pull requests, because it only depends on build-release without explicitly checking the trigger conditions. Although build-release depends on tag-release which has a condition for main branch, the dependency chain alone doesn't prevent the job from being triggered in other contexts.
Consider adding an explicit condition to ensure it only runs when intended:
publish-release:
needs: build-release
runs-on: ubuntu-latest
if: needs.tag-release.outputs.tag_created == 'true'
environment: pypi-productionThis makes the intent clear and adds an extra safety layer to prevent accidental publishes.
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-latest | |
| if: needs.tag-release.outputs.tag_created == 'true' |
This pull request introduces an automated PyPI release workflow and updates the project version for
snaplint. The main changes are focused on improving the release process and preparing for a new version deployment.Release workflow improvements:
publish-releasejob in.github/workflows/ci.ymlto automate publishing to PyPI, including setting the deployment environment topypi-productionand configuring trusted publishing permissions.Version update:
pyproject.tomlfrom0.4.2to0.5.0to reflect new changes and prepare for release.