Skip to content

Publish to pypi#1

Merged
ofekby merged 5 commits intomainfrom
publish-to-pypi
Dec 2, 2025
Merged

Publish to pypi#1
ofekby merged 5 commits intomainfrom
publish-to-pypi

Conversation

@ofekby
Copy link
Collaborator

@ofekby ofekby commented Nov 27, 2025

This pull request introduces a new release for snaplint, updating the version and enabling automated publishing to PyPI via GitHub Actions. The main changes include bumping the package version and activating the previously commented-out release workflow.

Release and publishing workflow updates:

  • Updated the package version in pyproject.toml from 0.4.2 to 0.5.0 to mark a new release.
  • Enabled the publish-release job in .github/workflows/ci.yml to automate publishing to PyPI using trusted publishing, which was previously commented out.

Copilot AI review requested due to automatic review settings November 27, 2025 14:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR intends to re-enable PyPI publishing in the CI workflow but only partially completes this task. The publish-release job structure is uncommented, but the actual PyPI publishing step remains commented out, meaning releases won't actually be published. Additionally, a period is incorrectly added to a README heading, breaking consistency with other headings.

  • Re-enabled the publish-release job structure but left the actual publishing step commented out
  • Added an inconsistent period to a markdown heading in the README

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
README.md Adds a period to "Local Installation" heading, creating inconsistency with other headings
.github/workflows/ci.yml Uncomments the publish-release job definition but leaves the actual PyPI publishing action commented out

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@OmriBenShoham OmriBenShoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ofekby ofekby merged commit 292651e into main Dec 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants