Skip to content

Conversation

@julienXX
Copy link

@julienXX julienXX commented Nov 1, 2013

  • Handle multiple operating systems
  • Use sox & terminal-notifier for OSX
  • Move from ExternalTools to a config file
  • Make the binary more UNIX-y (help with no args...)
  • Add an install command (prepare ~/.sbire ans so on)
  • Update README

Work in progress, not ready to be merged yet but here's the pull-request so that you can see what's coming.

@GCorbel
Copy link
Owner

GCorbel commented Nov 1, 2013

Thanks a lot! I will merge it whan you are ready.

@GCorbel
Copy link
Owner

GCorbel commented Nov 1, 2013

What do you think about to externalize commands called by Sbire. We could add, in the config file, this :

commands:
  notifier: "notify-send %{message}"
  recorder: "ffmpeg ... %{file_path}"

We can also create a default file for different systems. I can also be intersant to do a "install" command to create files and directories.

It is simpler for us, because we don't need to manage all commands made by the system, and more flexible for the use.

What you think?

@julienXX
Copy link
Author

julienXX commented Nov 1, 2013

Yeah that was the purpose of the ExternalTools class, but a yaml file is okay too. It would allow more customization from the users and perhaps more issues too.
We need to manage the commands used by Sbire a bit, just enough to at least provide a working template (ffmeg options and so on).
And +1000 for the install command, sbire is not user friendly at the moment.

@GCorbel
Copy link
Owner

GCorbel commented Nov 1, 2013

We can prepare a default file for each systems. For now, ffmpeg is mandatory because it's used by speech2Text but, I will be happy to remove it from the project. It is a probably something I will do later.

@onemanstartup
Copy link

any progress?
I'm getting sbire/notifier.rb:4:incall': undefined method %' for nil:NilClass error when running under mac os x

@GCorbel
Copy link
Owner

GCorbel commented Dec 9, 2014

@julienXX , can you try to update your pull request. @onemanstartup, can you try if this work : julienXX@43cf75a ?

@julienXX
Copy link
Author

julienXX commented Dec 9, 2014

I'll try to find some time to update it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants