-
Notifications
You must be signed in to change notification settings - Fork 3
OSX compatibility #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks a lot! I will merge it whan you are ready. |
|
What do you think about to externalize commands called by Sbire. We could add, in the config file, this : We can also create a default file for different systems. I can also be intersant to do a "install" command to create files and directories. It is simpler for us, because we don't need to manage all commands made by the system, and more flexible for the use. What you think? |
|
Yeah that was the purpose of the ExternalTools class, but a yaml file is okay too. It would allow more customization from the users and perhaps more issues too. |
|
We can prepare a default file for each systems. For now, ffmpeg is mandatory because it's used by speech2Text but, I will be happy to remove it from the project. It is a probably something I will do later. |
|
any progress? |
|
@julienXX , can you try to update your pull request. @onemanstartup, can you try if this work : julienXX@43cf75a ? |
|
I'll try to find some time to update it :) |
Work in progress, not ready to be merged yet but here's the pull-request so that you can see what's coming.