Google Charts library error correction and a loading text#2
Open
Quantium wants to merge 2 commits intoGAdevopsES:masterfrom
Open
Google Charts library error correction and a loading text#2Quantium wants to merge 2 commits intoGAdevopsES:masterfrom
Quantium wants to merge 2 commits intoGAdevopsES:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed an error related to the Google Charts library version that changes the way of the onLoadCallback is called.
Also, I have added a loading text and I have inactive the button until the data is loaded to avoid errors when the user click de button before the data is loaded
I hope this PR is useful