Factor out comment-searching code#94
Merged
Smaug123 merged 3 commits intoG-Research:mainfrom Aug 27, 2025
Merged
Conversation
Smaug123
commented
Aug 27, 2025
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Compile Include="Util.fs" /> | ||
| <Compile Include="Comments.fs" /> |
Contributor
Author
There was a problem hiding this comment.
Not a great name, I guess.
Member
|
Could you update the docs as well? |
Contributor
Author
|
I've already started to rely on having a bot tell me to do changes like those docs changes! I wonder if it's worth me putting a CLAUDE.md in this repo; internal GR automation would have caught the docs problem, and I'm wondering how to approximate that out here. |
Member
|
Would not opposite it. Poke me on the inside on what you are cooking, curious to hear more about the internal GR automation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have written another analyzer which also wants this functionality, so here's a standalone PR that factors it out.
This change is breaking, but hopefully in a fairly obvious way (the changed magic string, which makes the factored function simpler by only having to consider one string).