Extend the string analyzers to analyze uses of String.LastIndexOf in …#91
Merged
nojaf merged 2 commits intoG-Research:mainfrom Jul 1, 2025
Merged
Extend the string analyzers to analyze uses of String.LastIndexOf in …#91nojaf merged 2 commits intoG-Research:mainfrom
nojaf merged 2 commits intoG-Research:mainfrom
Conversation
…the same way it does for String.IndexOf This is laregely copy/pasted from the IndexOf analyzer, with just a few changes to the function names.
nojaf
reviewed
Jun 30, 2025
Member
nojaf
left a comment
nojaf
left a comment
There was a problem hiding this comment.
Thank you! Off to a good start here!
Add a changelog entry and ship it?
Contributor
Author
|
Changelog updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the same way it does for String.IndexOf
This is largely copy/pasted from the IndexOf analyzer, with just a few changes to the function names.
refs #21 (comment), where it brings a bit more parity with the simlar analyzers for C#.