Skip to content

Delete explicit SourceLink reference, which is in the SDK#53

Merged
Smaug123 merged 1 commit intomainfrom
remove-sourcelink
Feb 25, 2026
Merged

Delete explicit SourceLink reference, which is in the SDK#53
Smaug123 merged 1 commit intomainfrom
remove-sourcelink

Conversation

@Smaug123
Copy link
Contributor

@Smaug123 Smaug123 commented Feb 24, 2026

Per https://github.com/dotnet/sourcelink :

Starting with .NET 8, Source Link for the following source control providers is included in the .NET SDK and enabled by default: GitHub or GitHub Enterprise

Dependabot has started upgrading this package, which should be completely unnecessary anyway.

Supersedes #51

@Smaug123 Smaug123 requested review from a team as code owners February 24, 2026 19:09
@Smaug123
Copy link
Contributor Author

I checked the DLL using https://github.com/Smaug123/dotnet-pdb-analysis/ and it contains SourceLink metadata (observe the 404s, indicating that it tried to download the source for a generated file):

==== Examining file lib/netstandard2.0/HeterogeneousCollections.dll ====
Source linked obj dir (dubious check but it's what NuGetPackageExplorer does): /_//HeterogeneousCollections/obj/Release/netstandard2.0/.NETStandard,Version=v2.0.AssemblyAttributes.fs to https://raw.githubusercontent.com/G-Research/HeterogeneousCollections/97504f0589592c900a87d45fd695bf4b7c820c49//HeterogeneousCollections/obj/Release/netstandard2.0/.NETStandard,Version=v2.0.AssemblyAttributes.fs
Source linked to non-existent target: /_//HeterogeneousCollections/obj/Release/netstandard2.0/.NETStandard,Version=v2.0.AssemblyAttributes.fs to https://raw.githubusercontent.com/G-Research/HeterogeneousCollections/97504f0589592c900a87d45fd695bf4b7c820c49//HeterogeneousCollections/obj/Release/netstandard2.0/.NETStandard,Version=v2.0.AssemblyAttributes.fs, error response 404: Not Found

@Smaug123 Smaug123 merged commit 59ebb37 into main Feb 25, 2026
13 checks passed
@Smaug123 Smaug123 deleted the remove-sourcelink branch February 25, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants