Skip to content

Fix notifications being reversed when coming from external lock state changes (Unlock for lock, etc) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpw wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

Fix notifications being reversed when coming from external lock state changes (Unlock for lock, etc) #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions custom_components/keymaster/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,10 @@ async def _handle_lock_state_change(
if not event:
return

# Ignore events without a user_id - they're from zwave - let handle_zwave_js_lock_event handle it
if event.context.as_dict()["user_id"] is None:
Copy link
Collaborator

@firstof9 firstof9 Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be event.data.get("user_id") ?

Copy link
Author

@cpw cpw Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user_id isn't part of the data member of the event? As far as I can tell, it's only part of the context, which is a separate member.

Copy link
Collaborator

@firstof9 firstof9 Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if event.context.as_dict()["user_id"] is None:
if event.context.get("user_id") is None:

then we can do this instead.

Copy link
Author

@cpw cpw Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we can - as far as I can tell, the context object does not implement a Dict interface directly. Which is why I did as_dict() to get a dict out of it. As far as I can tell, it implements basically NO API at all. https://github.com/home-assistant/core/blob/7eb0f2993f25deba1fba9e4dcbcc8d13cf574482/homeassistant/core.py#L1243 - perhaps directly fetching the member would work?

return

changed_entity: str = event.data["entity_id"]

# Don't do anything if the changed entity is not this lock
Expand Down
Loading