-
Notifications
You must be signed in to change notification settings - Fork 52
refactor: First step of moving to internal functions: Minimum viable product #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
414a628 to
be1c816
Compare
946c571 to
7e9d95c
Compare
49c4138 to
7729f59
Compare
7729f59 to
112dd33
Compare
a30e648 to
a82f7bd
Compare
5b62e02 to
ba84cdb
Compare
Rename KeymasterLock entities from lock to kmlock Rename KeymasterLock parent to parent_name
ba84cdb to
83e4725
Compare
89f3388 to
4920fe0
Compare
092b8aa to
9e480a3
Compare
9e480a3 to
0a6178f
Compare
d9a24c1 to
fcd62e2
Compare
fcd62e2 to
06d24f0
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Changes that will require user intervention
code-quality
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
This is the barely minimum viable product for the first PR. The bulk of this PR is the refactor of the data model. Please do not merge this into main/master. Maybe into a beta branch for those who'd like to help or test?
Rebuild of keymaster to utilize internal functions
via_deviceproperty to link the parent lock to the child lockCurrent functionality in this PR
To Do in future PRs
Type of change
Additional information