Virtual Circuit fix - issue #47 #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added helper functions (get_xpoint_coordinate and get_strikepoint_r) to remove ~150 lines of duplication. Improved variable names for clarity. Simplified non-standard target handling with clearer indexing
georgeholt1
added
the
ready-for-final-tests
alasdairross
deleted the
issue-47/virtual_circuit_non_standard_targets_fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix relating to issue #47 . Updated virtual_circuits.py to allow an empty list of targets, i.e.
targets = []incalculate_targets(), as long asnon_standard_targetsare provided instead.Tested in my use case that highlighted this issue and checked that
example09 - virtual_circuits_MASTU.ipynbnotebook still runs correctly.