-
Notifications
You must be signed in to change notification settings - Fork 15
Remove deepcopying of profiles #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kpentland
merged 14 commits into
FusionComputingLab:main
from
timothy-nunn:remove-deepcopying-profiles
Oct 10, 2025
Merged
Remove deepcopying of profiles #44
kpentland
merged 14 commits into
FusionComputingLab:main
from
timothy-nunn:remove-deepcopying-profiles
Oct 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a5de47 to
fe1bb36
Compare
c752ef1 to
d5e4723
Compare
d5e4723 to
ea6aaee
Compare
79b0303 to
39cbd9c
Compare
Collaborator
|
This is excellent, thanks again Tim! I've been through and had no trouble on my end (barring the small commits made above). Ready to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
ready-for-final-tests
Pull request is ready to run final pre-merge tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes expensive deepcopies of profile objects.
The following table shows the % of the runtime for a 60 iteration example evolutive run that is spent deep copying objects.
main (10615f0)Overall, this results in a reduction in runtime spent in$21.12$ % on main to $16.96$ % on this branch.
stepping.nlstepper(linear evolutive example): going fromNote this PR will combine with #43 to remove the bulk of the overhead of copying objects.
I have compared history arrays of the coil currents, o-points, elongation, triangularity, squareness, separatrix area, and separatrix length between
mainand this PR. There is a 0 MAE between the non-linear example histories on main and in this PR, and a 0 MAE between the linear histories on main and in this PR.I have confirmed that example 01, 02, 03, 04, 05, 09, and 10 can run on this branch and produce the same results as on main (the example are all non-deterministic because the RNG is not seeded but they are qualitatively similar to examples as run on
main)