Remove bare try/except block that was suppressing useful exceptions #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpentland
added
the
ready-for-final-tests
georgeholt1
added
ready-for-final-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21 by simply removing the try/except block.
There may be other options that are preferable, but I found that the exceptions raised if the solver fails are useful. It looks like the intention with the try/except was to just catch if the initial guess failed, but as no exception handling was present it just skipped. If the initial guess fails, it's useful to know why, so I think it's best to just raise the exception directly.
If you would like specific handling, I could keep the try except and then raise the original exception with an additional note that this was on the initial guess.