Small patches #37
Merged
Small patches #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicamo
requested review from
georgeholt1 and
kpentland
and removed request for
georgeholt1
kpentland
approved these changes
Jun 21, 2025
Collaborator
kpentland
left a comment
kpentland
left a comment
There was a problem hiding this comment.
Changes look good - hopefully solver will not get stuck in weird situations anymore!
Ready to merge.
Collaborator
|
New changes look good to me @georgeholt1 - tested on some examples and see to work nicely. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a value error in jtor.py to address one of the modes in which the solver previously broke 'silently', resulting in it just getting stuck.
Also added masking beyond the secondary xpoint in cases close to double null, to avoid some (very rare) cases of spurious flooding (beyond the Xpt) of the plasma region.