Added function to compute 1D jtor profile #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'd be interested in this @nicamo! |
theo-brown
reviewed
Jun 6, 2025
| F_Q2[i] = np.sum( | ||
| (F2 * dV * mask) * self._profiles.limiter_core_mask | ||
| ) | ||
| except AttributeError as e: |
Contributor
There was a problem hiding this comment.
I think this should be catching TypeError? Or maybe both TypeError and AttributeError?
Sometimes limiter_core_mask can be None, and then you get a type error from trying to multiply a float by a None.
Collaborator
Author
There was a problem hiding this comment.
Do you have an example of this? Typically, this error pops up because self._profiles is not an attribute of the equilibrium object unless the equilibrium has been solved. Not sure I've seen a case where self._profiles.limiter_core_mask = None
added 2 commits
July 18, 2025 08:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a function to calculate the 1D jtor profile from the equilibrium. Please do check it makes sense.
This is required for the IMASification work.